feat(wfctl): natively sync registry core and readme#834
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the migration of wfctl plugin registry-sync away from bash fallbacks by implementing native Go logic for syncing workflow core plugin manifests and regenerating the workflow-registry README, and updates docs/help text to reflect the new behavior.
Changes:
- Implement native core plugin inspection (
go runinspector) + manifest drift detection/fixing forregistry-sync core. - Implement native README index rendering from registry manifests/templates for
registry-sync readme. - Update release-gate docs and CLI help to match the now-native implementation (including
--verify-capabilitiesno longer marked unimplemented).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/PLUGIN_RELEASE_GATES.md | Updates registry-sync documentation to reflect native wfctl ownership of core/readme sync behavior. |
| cmd/wfctl/plugin_registry_sync.go | Updates --verify-capabilities help text (no longer “not yet implemented”). |
| cmd/wfctl/plugin_registry_sync_test.go | Adds tests covering native README drift detection and core manifest drift detection/fix behavior. |
| cmd/wfctl/plugin_registry_sync_readme.go | Replaces bash fallback with native README rendering from manifests/templates. |
| cmd/wfctl/plugin_registry_sync_core.go | Replaces bash fallback with native core plugin inspection + registry manifest syncing. |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses part of #762. This intentionally leaves workflow-registry wrapper/script removal and any remaining registry cron migration as follow-up cascade work.
Verification